-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose Milestone redesign #1214
Comments
So here I would just go for 3 options: Milestone / Payment / Expense When you get a propose/create a new Milestone you get a pop up with these 3 choices + brief explanation under buttons what they are. With it comes a dropdown box under a Campaign, by default it just shows the Milestones (as people want to donate to Milestones mainly). If they change the dropdown they can see payments & expenses for transparency reasons only. |
Hey, @krrisis I'll be working on the UI and flow of this issue. |
You add an intermediary pop-up that lets you choose between 3 options (got out my very best design skills)
The advantage of this approach is that we incentivize people to only donate to Campaigns and only to Milestones under it if these Milestones are really Milestones for the project that's set up, not ordinary payments. Money from Campaigns & Milestones is delegated to payments & expenses for individuals. I can make more quick (super sexy :) ) designs for how I see the 'Milestones' but prob waste of time if Griff sees the detail differently |
Thanks @krrisis this helps. I'm going to make a more polished mockup and send over when ready. |
Considering making this as a standalone action with this being the first step. @GriffGreen @krrisis |
I love it!! and hope @GriffGreen will agree to leave bounties out for now, makes it easier :) I think the 'create new' also makes sense. |
@krrisis While we're at that, I think it would be better to have tabs right away: Milestones | Expenses | Payments so that we don't hide options under a dropdown or an icon. I'll mock this up in the next iteration. Thanks for pointing this out! |
@krrisis @GriffGreen Payments and Expenses forms might have different inputs required than the Milestone. For example... Expenses:
Payments:
Another thing that came up while I'm redesigning this is the concept of allowing user to add a Milestone/Expense/Payment from anywhere on Giveth. |
That is super cool @markoprljic ... I will bring that up in the sync call today. |
This is great! Made some comments |
The big question is if it is worth separating the bounties use case from the payments use case in order to reduce the options for payments in the next screen |
Another question is whether or not we can use the standard bootstrap methods for building this or if we should try to match the design perfectly |
Amin said that would be cool! And maybe we put it on the home page @markoprljic? |
Thanks @GriffGreen, I meant just how much job we will have on designing component? Is there ready component/libraries out there that match the design? |
Doesn't have to match design perfectly, we can use the library we have and apply to this layout and UI. |
btw. what framework are we using? Maybe I can continue design iterations with those components. @aminlatifi ? |
I added the Bounty option https://www.figma.com/proto/FBqHg0UfeuaIueDEZG0tBS/Giveth-Design?node-id=2072%3A841&viewport=159%2C255%2C0.10972581803798676&scaling=min-zoom Blocker: I need to know what input fields and options are mandatory on this page @GriffGreen |
@GriffGreen Please review the following: cc/ @aminlatifi |
Are there any current options on Giveth 1.0 to create/use a milestone template? |
Goal here is to make lots of small issues @aminlatifi and then assign to @MohammadPCh |
All tests passed except: 1- Edit Milestone goes to old form (By milestone creator in his profile, or by the campaign owner when he/she wants to edit) |
|
@MoeNick In new forms there is a delete button in bottom right corner |
1- So I will create one issue in product backlog. |
2- I guess it doesn't block this one, we can release this version with this issue. Let's assign it to @MohammadPCh, I hope he have bandwidth for it. |
I move
Let it be blocked Amin, it is kinda bug and a bad UX. Hope will merge with #1988 together. |
https://docs.google.com/spreadsheets/d/1BTG_BluAahVGog_R-Ubt2a93POiA84RHU3NqiXaUog0/edit#gid=0
Lets limit it to 4 types of milestones:
Payments
Expenses
Milestones
Bounties
This will probably be an epic and starts with a designer
The text was updated successfully, but these errors were encountered: