Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Elm 0.19 #3

Merged
merged 1 commit into from Sep 18, 2018
Merged

Upgrade to Elm 0.19 #3

merged 1 commit into from Sep 18, 2018

Conversation

jackfranklin
Copy link
Contributor

Hello,

Thanks for the work on this! This PR upgrades the package to 0.19. I'd be grateful if you could merge + publish this as we rely on it in production and we'd love to get onto 0.19 soon :)

I ditched the examples/Window.elm as elm make doesn't allow an effect manager.

@rgrempel
Copy link
Collaborator

Thanks for this, and for your work on the proper-keyboard dependency!

I'll review this ASAP.

@rgrempel
Copy link
Collaborator

I've read through this quickly -- looks good -- thanks again.

I'll go ahead and merge this and then make a few more tweaks.

@rgrempel rgrempel merged commit 0fcab33 into Gizra:master Sep 18, 2018
@rgrempel
Copy link
Collaborator

I've published version 1.0.1 for Elm 0.19.

Thanks again for your work on this. I took the opportunity to re-write the documentation, to take into account various changes between Elm 0.18 and 0.19.

For listening to global keypresses, it turns out that Elm 0.19 is actually improved, because the listeners in Browser.Events let you provide your own decoder. (Previously, they only gave you access to the KeyCode). So, I was able to restore the "listen to global events" example -- you don't need to write your own effects manager to do that in Elm 0.19, which is nice.

@jackfranklin
Copy link
Contributor Author

@rgrempel thanks for acting so promptly on this! That's great news about global keypresses, sorry I didn't realise that yesterday. Thanks so much for merging + your work on this module :)

@jackfranklin jackfranklin deleted the elm-19 branch September 19, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants