Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #545

Closed
3 tasks done
pfrenssen opened this issue Jul 23, 2019 · 1 comment
Closed
3 tasks done

Remove unused variables #545

pfrenssen opened this issue Jul 23, 2019 · 1 comment
Labels
Clean-up Drupal 8 Good first issue
Milestone
8.x-1.0-alpha5

Comments

@pfrenssen
Copy link
Contributor

pfrenssen commented Jul 23, 2019 •
edited

  • Remove the following line from phpcs-ruleset.xml.dist:
    <exclude name="DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable" />
  • Run ./vendor/bin/phpcs
  • Fix all reported warnings.
@pfrenssen pfrenssen mentioned this issue Jul 23, 2019
Merged
@kbrodej kbrodej mentioned this issue Dec 24, 2019
Merged
@pfrenssen
Copy link
Contributor Author

Fixed in #604

@pfrenssen pfrenssen added this to the 8.x-1.0-alpha5 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean-up Drupal 8 Good first issue
Projects
None yet
Milestone
8.x-1.0-alpha5
Development

No branches or pull requests
1 participant
@pfrenssen