Removed unused variables #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrodej
force-pushed
the
hotfix/remove-unused-variables-#545
branch
from
dd62230
to
56be162
Compare
MPParsley
reviewed
Jan 6, 2020
src/ContextProvider/OgContext.php
Outdated
| @@ -135,8 +134,7 @@ protected function getBestCandidate() { | |||
| foreach ($group_resolvers as $plugin_id) { | |||
| /** @var \Drupal\og\OgGroupResolverInterface $plugin */ | |||
| if ($plugin = $this->pluginManager->createInstance($plugin_id)) { | |||
| $plugins[$plugin_id] = $plugin; | |||
|
|
|||
| // $plugins[$plugin_id] = $plugin; | |||
There was a problem hiding this comment.
this doesn't seem right?
There was a problem hiding this comment.
Fixed in the next commit.
pfrenssen
suggested changes
Jan 29, 2020
There was a problem hiding this comment.
Thanks for working on this! This is looking good, except for one case: PHP_CodeSniffer cannot understand the way that our test is using a variable assignment to trigger an exception. Instead of adding a fake line that returns the value, we should just disable this coding standards check for this case.
This is preferred over introducing unneeded logic to work around the false positive.
pfrenssen
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #545