Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event dispatcher BC #725

Open
MPParsley opened this issue Jul 16, 2021 · 1 comment · May be fixed by #733
Open

Fix event dispatcher BC #725

MPParsley opened this issue Jul 16, 2021 · 1 comment · May be fixed by #733
Labels
Clean-up Drupal 9

Comments

@MPParsley
Copy link
Collaborator

The arguments to the event dispatcher are backwards compared to expected (some BC code in Symfony is allowing it for now):

$this->eventDispatcher->dispatch(GroupCreationEventInterface::EVENT_NAME, $event);

3:55
that’s in several places (the reversed arguments) (edited)
@pfrenssen
Copy link
Contributor

Seems we have a lot of deprecated calls :)

  2196x: Calling the Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch() method with a string event name as the first argument is deprecated in drupal:9.1.0, an Event object will be required instead in drupal:10.0.0. See https://www.drupal.org/node/3154407

pfrenssen added a commit that referenced this issue Dec 17, 2021
@pfrenssen
Signature of EventDispatcherInterface::dispatch() has changed
ac9d2af 
In Drupal 9.1 the order of the arguments to this method has been changed.
Ref. https://www.drupal.org/node/3154407

Fixes #725.
@pfrenssen pfrenssen linked a pull request Dec 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean-up Drupal 9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signature of EventDispatcherInterface::dispatch() has changed Gizra/og
2 participants
@pfrenssen @MPParsley