-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor \Drupal\og_ui\BundleFormAlter #734
Open
pfrenssen
wants to merge
15
commits into
8.x-1.x
Choose a base branch
from
bundleformalter-wrong-type
base: 8.x-1.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… BundleEntityFormBase.
After spending some quality time with the class I am realizing it would better be converted into a service, since it depends on a bunch of other services such as the |
This is ready but blocked by #732. Assigning to me to keep track. |
Now that #732 has been merged, this is unblocked and ready for review. Unassigning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\Drupal\og_ui\BundleFormAlter
class is in need of refactoring and bug fixing.In #733 new scalar type hints are being introduced, and the testing of this has uncovered that the
BundleFormAlter
class is calling intoOg::isGroup()
with the$bundle_id
set toNULL
, while this method is only accepting strings.Apart from this bug the class is also showing its age and is not up to date with current best practices. Let's:
::prepare()
method then acts as a second constructor which populates further properties. Internally then the form and form state are still passed on between methods. It looks like this can be simplified a lot, by just passing on the form and form state and using some basic helper methods. It looks like the whole class can operate without keeping any state, with purely static methods.