Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed building with Visual Studio 2017 #156

Closed
wants to merge 2 commits into from
Closed

Fixed building with Visual Studio 2017 #156

wants to merge 2 commits into from

Conversation

AnotherFoxGuy
Copy link

Also includes an appveyor.yml file; Fixes #92

@hhirsch
Copy link
Member

hhirsch commented Mar 11, 2018

@AnotherFoxGuy Build fails. pkg_search_module(EPOXY REQUIRED epoxy) is required.

Copy link
Member

@hhirsch hhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use both and and not intentionally. The whole code base already builds in VS2017 so there should be no code changes needed. See build instructions for VS in COMPILE.md and README.md

@AnotherFoxGuy
Copy link
Author

AnotherFoxGuy commented Mar 12, 2018

@hhirsch We use both and and not intentionally.

You should probably add that to the coding guidelines since this is the first C++ project I've seen that uses the alternative logical operators

The reason that I've changed it is that the alternative logical operators won't compile by default with VS2017, see: https://stackoverflow.com/questions/24414124/why-does-vs-not-define-the-alternative-tokens-for-logical-operators
You need to include the header file iso646.h, or compile with the /Za (Disable language extensions) compiler option

Also, the code base seems to use a mixture of && and and

@hhirsch hhirsch closed this Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants