Fix bugs and write tests for Raster.value_at_coords()
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhugonnet
changed the title
Raster.value_to_coords()Raster.value_at_coords()
adehecq
reviewed
Feb 9, 2023
adehecq
reviewed
Feb 9, 2023
adehecq
reviewed
Feb 9, 2023
adehecq
reviewed
Feb 9, 2023
adehecq
reviewed
Feb 9, 2023
adehecq
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
value_at_coordsfunction, adds the functionality of passing an array-like object of coordinates, and fixes minors bugs.It looks like more changes than there actually is in the "Files changed". Owing to shifting blocks of code in
value_at_coordsto be either in or out of the loop (added for array-like).There's also a setup bug with
isortthat they recommend to fix by upgrading to5.12.0(will need the same in xDEM): moved to #343.Resolves #324
Resolves #245