Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #451 and improve tests for downsampling #452

Merged
merged 1 commit into from Jan 26, 2024
Merged

Fix #451 and improve tests for downsampling #452

merged 1 commit into from Jan 26, 2024

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Jan 25, 2024

rhugonnet
rhugonnet approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@rhugonnet rhugonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🤩
Short fix in the end and most of the work was to make the (infinitely) better tests (it's nice to see all raster examples used too), thanks!!

@adehecq adehecq merged commit c9c9a84 into GlacioHack:main Jan 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhugonnet rhugonnet rhugonnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raster.bounds is incorrect with downsampling
2 participants
@adehecq @rhugonnet