Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Raster.shift() into Raster.translate and add inplace argument to Vector.translate #579

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Rename Raster.shift() into Raster.translate and add inplace argument to Vector.translate #579

merged 4 commits into from
Jun 13, 2024

Conversation

rhugonnet
Copy link
Contributor

Turns out Vector.translate already existed (from Geopandas), so renaming Raster method to match instead.

Resolves #569

adehecq
adehecq approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update the documentation again ! 😅
And I will need to update many of my script 😢
But it's sensible to match geopandas.

@rhugonnet
Copy link
Contributor Author

Yes 😅. I checked and there's only two calls in a test function in xDEM thankfully

@rhugonnet rhugonnet merged commit 80f43fd into GlacioHack:main Jun 13, 2024
13 checks passed
@rhugonnet rhugonnet deleted the add_vector_shift branch June 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehecq adehecq adehecq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vector.shift() function mirroring Raster.shift()
2 participants
@rhugonnet @adehecq