Skip to content

Commit

Permalink
Fix deprecate version check (#309)
Browse files Browse the repository at this point in the history
* Fix version check

* Linting
  • Loading branch information
rhugonnet committed Sep 26, 2022
1 parent 03276a5 commit 50fa735
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion xdem/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import warnings
from typing import Any, Callable

from packaging.version import Version

try:
import cv2

Expand Down Expand Up @@ -79,7 +81,7 @@ def deprecator_func(func: Callable[[Any], Any]) -> Callable[[Any], Any]:
@functools.wraps(func) # type: ignore
def new_func(*args: Any, **kwargs: Any) -> Any:
# True if it should warn, False if it should raise an error
should_warn = removal_version is None or removal_version > xdem.version.version
should_warn = removal_version is None or Version(removal_version) > Version(xdem.version.version)

# Add text depending on the given arguments and 'should_warn'.
text = (
Expand Down

0 comments on commit 50fa735

Please sign in to comment.