Fix Deramp #202
Merged
Fix Deramp #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
erikmannerfelt
approved these changes
Aug 19, 2021
adehecq
reviewed
Aug 25, 2021
| @@ -1055,15 +1056,14 @@ def residuals(coefs: np.ndarray, x_coords: np.ndarray, y_coords: np.ndarray, tar | |||
| ddem = ddem[indices] | |||
|
|
|||
| # Optimize polynomial parameters | |||
| coefs = scipy.optimize.fmin( | |||
| coefs = scipy.optimize.leastsq( | |||
There was a problem hiding this comment.
Good catch! I wonder why fmin was used here... I checked and it doesn't seem to come from my older implementation...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deramping was not correcting tilts properly.
Output of Deramp before fix
After fix
Now I can see my jitter quite clearly!
Still need to deal with that one 😅
Further steps
We need more tests, and more plotting functionalities to check our outputs! They are quite complex spatially, so just relying on some calculations through
pytestroutines is probably not enough (at least for their initial setup)