Fix nan skipping in patches method #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
rhugonnet
changed the title
erikmannerfelt
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the patches method where a patch was skipped if the central pixel was NaN, a behavior that discarded lots of valid patches within the
perc_validrange.I think this line was originally introduce to improve processing time for raster with a lot of no data, but I didn't see any difference when generating the docs, so seems all good. I used it on a Raster with quite a bit of NaNs, but maybe not as much as those where there is almost no stable terrain available...
I think we discussed this at one point @erikmannerfelt? Do you remember the ouput?