Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bugs in spatialstats #230

Merged
merged 15 commits into from
Nov 8, 2021
Merged

Fixes bugs in spatialstats #230

merged 15 commits into from
Nov 8, 2021

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Nov 5, 2021 •
edited
Loading

  • Fixes legend plotting zorder in plot_vgm
  • Fixes reshaping of final array in interp_nd_binning (needed to specify the indexing='ij' argument for np.meshgrid to work as intended)
  • Added tests in test_spatialstats.py to check dimension order and of varying length for interp_nd_binning

Ready to be merged 😄

@rhugonnet
Copy link
Contributor Author

@erikmannerfelt Don't forget there's this one as well, as you've reviewed the other two 😉

erikmannerfelt
erikmannerfelt approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@erikmannerfelt erikmannerfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll! I would have preferred the triple loop that you added to have and associated comment, but otherwise it looks very good!

@rhugonnet rhugonnet merged commit 2564f5f into GlacioHack:main Nov 8, 2021
@rhugonnet rhugonnet deleted the fixes_spatialstats branch November 8, 2021 12:14
@rhugonnet rhugonnet restored the fixes_spatialstats branch November 8, 2021 12:14
@rhugonnet rhugonnet deleted the fixes_spatialstats branch November 8, 2021 12:14
@rhugonnet
Copy link
Contributor Author

@erikmannerfelt Thanks! All part of the same heading comment so I left as is.
FYI: this means that the ND-binning interpolation was inverting dimensions, if you were using it. The example in docs will change consequently.

@rhugonnet rhugonnet mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmannerfelt erikmannerfelt erikmannerfelt approved these changes

@adehecq adehecq Awaiting requested review from adehecq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhugonnet @erikmannerfelt