Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explicit dependencies with discrepancies found by conda-forge bot #278

Merged
merged 18 commits into from
Aug 9, 2022

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Aug 9, 2022

geopandas was listed but unused
numpy, fiona, shapely and autovizwidget (not imported but used for plotting in the gallery examples) were used but not listed

Ran into a strange numba error on the first CI run, now gone... I remember having this issue 6 months ago already, which also disappeared by itself.
It's quite incomprehensible, so I added a point in the wiki:

  1. The baffling: numba sometimes does not recognized expressions such as sum (e.g., https://github.com/GlacioHack/xdem/runs/7742646090?check_suite_focus=true) while clearly supported (https://numba.readthedocs.io/en/stable/reference/pysupported.html?highlight=sum). Probably because of a slightly different environment setup by mamba, but still... The one who solves that one will get a cake.

Resolves #273

Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@rhugonnet rhugonnet merged commit 649fdd8 into GlacioHack:main Aug 9, 2022
@rhugonnet rhugonnet deleted the adjust_dependencies branch August 9, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update unused or missing dependencies for next release (conda-forge bot)
2 participants