Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with GeoUtils data.setter and __array_interface__ update #301

Merged
merged 15 commits into from
Sep 18, 2022

Conversation

rhugonnet
Copy link
Contributor

Updating a couple tests that used syntax only supported by the previous __array_interface__ or raised UserWarning due to the new data.setter of Raster.
Will make CI pass once GlacioHack/geoutils#302 is merged.

@rhugonnet
Copy link
Contributor Author

rhugonnet commented Sep 17, 2022

I finally found the source of the errors (it's been 2 weeks)! Parallelized tests run automatically with pytest-xdist, and this started impacting Raster reading/writing (maybe because of some issue in a low-level dependency).
The issue for tracking this, is that the effect was that sometimes (randomly) the grid was read as full of nodata.

Locally, we rarely run with pytest -n=auto, which is why we could not reproduce it. Here's the fix: 0a59b42

Added a comment and closed: GlacioHack/geoutils#293 (comment). In the end, this is not related to floating nodata at all...

@rhugonnet
Copy link
Contributor Author

rhugonnet commented Sep 18, 2022

Merging this, as only 2 lines have changed: the pytest-xdist fix + the commit hash for the new xdem-data with nodata changed to -9999. We can decide later if we keep this new -9999, or revert to the floating nodata.

@rhugonnet rhugonnet merged commit 60fed0f into GlacioHack:main Sep 18, 2022
@rhugonnet rhugonnet deleted the update_geoutils_arrayinterface branch September 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants