Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecate version check #309

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Fix deprecate version check #309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52bab87
Fix version check
rhugonnet Sep 26, 2022
ad2e26c
Linting
rhugonnet Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xdem/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import warnings
from typing import Any, Callable

from packaging.version import Version

try:
import cv2

Expand Down Expand Up @@ -79,7 +81,7 @@ def deprecator_func(func: Callable[[Any], Any]) -> Callable[[Any], Any]:
@functools.wraps(func) # type: ignore
def new_func(*args: Any, **kwargs: Any) -> Any:
# True if it should warn, False if it should raise an error
should_warn = removal_version is None or removal_version > xdem.version.version
should_warn = removal_version is None or Version(removal_version) > Version(xdem.version.version)

# Add text depending on the given arguments and 'should_warn'.
text = (
Expand Down