Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make opencv import optional #319

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Make opencv import optional #319

merged 3 commits into from
Oct 17, 2022

Conversation

adehecq
Copy link
Member

@adehecq adehecq commented Oct 14, 2022 •
edited by rhugonnet
Loading

Resolves #318

@rhugonnet
Copy link
Contributor

Nice! I noticed the CI error was because you needed to keep import cv2 as cv instead of just import cv2 and fixed it 😄. Should be ready to merge after checks.

rhugonnet
rhugonnet previously approved these changes Oct 16, 2022
View reviewed changes
@adehecq adehecq merged commit 81abcc8 into GlacioHack:main Oct 17, 2022
@rhugonnet rhugonnet mentioned this pull request Oct 17, 2022
Closed
@adehecq adehecq deleted the opencv branch October 17, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhugonnet rhugonnet rhugonnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opencv no longer an optional dependency
2 participants
@adehecq @rhugonnet