Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of processed examples in examples.py #328

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

rhugonnet
Copy link
Contributor

This PR fixes a bug in the function process_coregistered_examples of examples.py that made the ddem processing run every time the file was called with xdem.example.get_path("longyearbyen_ddem"). This should save us some time in testing and building documentation! 😄

Additionally, it makes the variables FILEPATHS_DATA and FILEPATHS_PROCESSED not accessible to users (adding _ in front), and create the xdem.examples.available variable that list keys of both dictionaries that can be called with xdem.examples.get_path(), for consistency with GeoUtils GlacioHack/geoutils#284.

@rhugonnet rhugonnet changed the title Fix processed examples loading in examples.py Fix loading of processed examples in examples.py Oct 25, 2022
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! And nice that it is now consistent with geoutils.

@rhugonnet rhugonnet merged commit 4506b6d into GlacioHack:main Oct 25, 2022
@rhugonnet rhugonnet deleted the fix_processed_examples branch October 25, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants