Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with new GeoUtils (casting single-band to 2D, implicit loading, new module names) #341

Merged
merged 9 commits into from
Apr 17, 2023

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Mar 4, 2023

To fix all issues that arose with GlacioHack/geoutils#360 (including GlacioHack/geoutils#351).

Resolves #342
Might resolve #323, as #186 only tested errors in BlockwiseCoreg.fit() and not in BlockwiseCoreg.apply()

This PR only fixes what is in xdem/ and tests/, what is in doc/ will be done in #303 to avoid a merging nightmare.

@rhugonnet rhugonnet marked this pull request as draft March 4, 2023 00:28
@rhugonnet rhugonnet changed the title Update features with GeoUtils v0.1 Update with GeoUtils' new behaviour (casting single-band to 2D, implicit loading) Apr 17, 2023
@rhugonnet rhugonnet changed the title Update with GeoUtils' new behaviour (casting single-band to 2D, implicit loading) Update with new GeoUtils (casting single-band to 2D, implicit loading, new module names) Apr 17, 2023
@rhugonnet rhugonnet marked this pull request as ready for review April 17, 2023 02:38
@rhugonnet rhugonnet merged commit 224a9ea into GlacioHack:main Apr 17, 2023
@rhugonnet
Copy link
Contributor Author

Merging now to continue fixes linked to doc in #303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make nmad applicable directly to Raster ValueError for xdem.coreg.BlockwiseCoreg()
1 participant