Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spatialstats test based on time that randomly fails #355

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Remove spatialstats test based on time that randomly fails #355

merged 1 commit into from
Apr 19, 2023

Conversation

rhugonnet
Copy link
Contributor

Opening an issue, there's probably a better way of testing this.

@rhugonnet rhugonnet mentioned this pull request Apr 19, 2023
Open
erikmannerfelt
erikmannerfelt approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@erikmannerfelt erikmannerfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the GitHub CI can get congested with other stuff and randomly introduce delays? I'd say it's good enough with just the approx equals test!

@rhugonnet rhugonnet merged commit 8e48799 into GlacioHack:main Apr 19, 2023
@rhugonnet rhugonnet deleted the remove_time_test branch April 19, 2023 17:30
@erikmannerfelt erikmannerfelt mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmannerfelt erikmannerfelt erikmannerfelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhugonnet @erikmannerfelt