Fix inheritance diagram rendering in documentation #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the inheritance diagrams rendering in the doc (that was shown as text).
Inheritance diagrams require
graphvizto build. However,mambahas trouble updating the baseenvironment.ymlwithgraphvizin the CI (that runs into two steps: base environment + update with dev packages), because some image-processing package dependencies are similar.To fix this, this PR explicitly adds
graphvizwhen building the baseenvironment.ymlonly in the CI.All other scripts building from
dev-environment.ymlare functioning fine (readthedocs, developper install).Also, it changes the color of edges to more adequately display inheritance diagrams in dark or light mode (background of text stays white, see: pydata/pydata-sphinx-theme#820)
Resolves #359