Update contributing guidelines to be more accessible #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adehecq
reviewed
Sep 7, 2023
adehecq
reviewed
Sep 7, 2023
adehecq
previously approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks for updating this outdated file.
I anticipate that some of it will be outdated in some time, for example the Python version used etc. Is there a good way to remind us to update this file when we make such changes?
Maybe we should have a list of things to do when marking a new (major) release? Including updating this file.
|
Good point, I think it's more related to specific dev-changes than necessarily version release, so I added a check-box to the PR template for now (easy to delete the line when not relevant). We can see how that works! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #414