Add Coreg.fit_and_apply() to run everything in one step
#527
Conversation
| @@ -25,14 +25,15 @@ class TestRobustFitting: | |||
| def test_robust_norder_polynomial_fit(self, pkg_estimator: str) -> None: | |||
|
|
|||
| # Define x vector | |||
| x = np.linspace(1, 10, 1000) | |||
| x = np.linspace(-50, 50, 10000) | |||
There was a problem hiding this comment.
This is to reduce random errors triggered on Mac sometimes (strange because random_state is fixed... Couldn't find a logical explanation).
| @@ -1351,6 +1351,140 @@ def apply( | |||
| else: | |||
| return applied_elev, out_transform | |||
|
|
|||
| @overload | |||
| def fit_and_apply( | |||
There was a problem hiding this comment.
Simple !
I think 99% of the users will only need to use that function. Maybe we could just add a note in the other functions fit and apply that this one should be used in priority. The only reasons I can see to split the two is 1) if making changes to the coregistration or 2) to run the same coregistration to several DEMs. Do you see any other reason?
It would almost make sense to hide the two step functions...
There was a problem hiding this comment.
I added an issue to make sure we update the examples in the doc to encourage using this function: #532
Resolves #513