Fix #1163: In scene, when deleting a trigger, it should not mix devic…

…e feature data

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>

front/src/components/device/SelectDeviceFeature.jsx

@@ -52,12 +52,6 @@ class SelectDeviceFeature extends Component {
       });
       await this.setState({ deviceOptions, deviceFeaturesDictionnary, deviceDictionnary });
       await this.refreshSelectedOptions(this.props);
-      if (this.state.selectedOption && this.state.selectedOption.value) {
-        this.props.onDeviceFeatureChange(
-          deviceFeaturesDictionnary[this.state.selectedOption.value],
-          deviceDictionnary[this.state.selectedOption.value]
-        );
-      }
       return deviceOptions;
     } catch (e) {
       console.error(e);
@@ -76,6 +70,7 @@ class SelectDeviceFeature extends Component {
   };
   refreshSelectedOptions = async nextProps => {
     let selectedOption = '';
+    const { selectedOption: originalSelected } = this.state;
     if (nextProps.value && this.state.deviceOptions) {
       let deviceOption;
       let i = 0;
@@ -88,7 +83,19 @@ class SelectDeviceFeature extends Component {
         selectedOption = deviceOption;
       }
     }
+
     await this.setState({ selectedOption });
+
+    if (originalSelected !== selectedOption) {
+      if (selectedOption) {
+        this.props.onDeviceFeatureChange(
+          this.state.deviceFeaturesDictionnary[selectedOption.value],
+          this.state.deviceDictionnary[selectedOption.value]
+        );
+      } else {
+        this.props.onDeviceFeatureChange(null, null);
+      }
+    }
   };
   constructor(props) {
     super(props);