Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard edit menu - add buttons Save/Cancel #779

Closed
Terdious opened this issue May 9, 2020 · 5 comments
Closed

Dashboard edit menu - add buttons Save/Cancel #779

Terdious opened this issue May 9, 2020 · 5 comments
Assignees
@atrovato
Labels
enhancement
Projects
Gladys 4 Development
Milestone
Gladys Assistant ...

Comments

@Terdious
Copy link
Contributor

Terdious commented May 9, 2020

In the "edit" window of the dashboard, once the scroll bar has appeared after placing a certain number of cards, it would be useful to have the "Save" and "Cancel" buttons at the bottom of the page.
@atrovato
Copy link
Contributor

atrovato commented May 9, 2020

Hi, what do you think about something like a fixed bottom bar?

dashboard-fixed-edit-bar

atrovato added a commit to atrovato/Gladys that referenced this issue May 9, 2020
@atrovato
Fix GladysAssistant#779 fixed bottom dashboard edition bar
5584455
@atrovato atrovato mentioned this issue May 9, 2020
Merged
3 tasks
@atrovato atrovato self-assigned this May 9, 2020
@atrovato atrovato added this to the Gladys 4 RC milestone May 9, 2020
@atrovato atrovato added this to In progress in Gladys 4 Development May 9, 2020
@Terdious
Copy link
Contributor Author

For my part I find it perfect !! I let @Pierre-Gilles validate ^^
Thank you very much @atrovato

@Pierre-Gilles
Copy link
Contributor

Hi, what do you think about something like a fixed bottom bar?

It's really nice, but what happened to your dashboard? Seems there is no card anymore? Is it a side effect or just a test?

@atrovato
Copy link
Contributor

It is because of the the gif screenshot application. There is no changes on cards.

@Pierre-Gilles
Copy link
Contributor

Ok ! I'll have a look at the PR, looks good to me :)

Pierre-Gilles added a commit to atrovato/Gladys that referenced this issue May 18, 2020
@Pierre-Gilles
Merge branch 'master' into fix-GladysAssistant#779-dashboard-edit-sav…
b212228 
…e-button
Pierre-Gilles added a commit to atrovato/Gladys that referenced this issue May 18, 2020
@Pierre-Gilles
Merge branch 'master' into fix-GladysAssistant#779-dashboard-edit-sav…
b1adc1c 
…e-button
atrovato added a commit to atrovato/Gladys that referenced this issue May 21, 2020
@atrovato
Fix GladysAssistant#779 fixed bottom dashboard edition bar
cc803ec
Pierre-Gilles added a commit to atrovato/Gladys that referenced this issue May 25, 2020
@Pierre-Gilles
Merge branch 'master' into fix-GladysAssistant#779-dashboard-edit-sav…
27f9885 
…e-button
Pierre-Gilles added a commit to atrovato/Gladys that referenced this issue May 25, 2020
@Pierre-Gilles
Merge branch 'master' into fix-GladysAssistant#779-dashboard-edit-sav…
0829a4d 
…e-button
Gladys 4 Development automation moved this from In progress to Done May 25, 2020
NickDub-old pushed a commit to NickDub/Gladys that referenced this issue Aug 7, 2020
@atrovato @Pierre-Gilles @NickDub
Fix GladysAssistant#779 : The dashboard save & cancel button are fixed (
e7d5448 
GladysAssistant#783)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
R6n0 pushed a commit to R6n0/Gladys that referenced this issue Dec 2, 2020
@atrovato @Pierre-Gilles
Fix GladysAssistant#779 : The dashboard save & cancel button are fixed (
dcfb14c 
GladysAssistant#783)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrovato atrovato

Labels
enhancement
Projects
Gladys 4 Development
  
Done
Milestone
Gladys Assistant 4 RC
Development

No branches or pull requests
3 participants
@atrovato @Pierre-Gilles @Terdious