Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a device category/type for rolling shutters #934

Closed
Pierre-Gilles opened this issue Nov 9, 2020 · 10 comments
Closed

Add a device category/type for rolling shutters #934

Pierre-Gilles opened this issue Nov 9, 2020 · 10 comments

Comments

@Pierre-Gilles
Copy link
Contributor

Functional specs

It should be able to be open/close with different levels:

  • 0%
  • 25% if supported?
  • 50%
  • 75% if supported?
  • 100%

To do

  • Imagine a design to simply move the shutters in the UI (Maybe a set of buttons?, or a slide?)
  • See how we can supports different types of devices which supports only 2 states (on/off), only 3 states (0-50-100%), only 4 states (0-25-50-100%), only 5....
  • How does it work for MQTT users?

@atrovato any opinion on that for the MQTT part ? It was asked by a MQTT user

@atrovato
Copy link
Contributor

atrovato commented Nov 9, 2020

Not sure to understand the question, but I think a int 0 - 100 a percent is doing it well.
Let me check on Tasmota service if I already defined it.

Dashboard display is another question.

@Pierre-Gilles
Copy link
Contributor Author

Pierre-Gilles commented Nov 9, 2020

I'm talking about user experience ! It doesn't solve the problem, how do you know on the UI side which percentage the device supports?

I had a feedback of a user which had shutters which only supports 0, 50 et 100%.

So a slider doesn't work, it needs to be like 3 buttons [closed] [50%] [open]

But this is not generic, because as I said another users can have a rolling shutters with another configuration.

The question is how to make this easy to specify for the user

@Pierre-Gilles
Copy link
Contributor Author

I'm thinking about it 😃

@Pierre-Gilles
Copy link
Contributor Author

When thinking about it, it's maybe more a general question : how do we handle devices with specific functions ?

For example devices with multi-states button ? (0, 1, 2)

How do we define them in an "open" services like MQTT ?

@atrovato
Copy link
Contributor

atrovato commented Nov 9, 2020

What about a [ up | stop | down ] swith?

@Pierre-Gilles
Copy link
Contributor Author

It's not the question ! How do you know that the roller shutter supports up / stop / down ?

The question is : Right now in Gladys, we only handle a simple type in the UI : On/Off.

How do we handle multi-state types ?

  • How do we represent them in DB ?
  • How does the service tells Gladys "My device supports this, this and this". ?
  • How do we handle service like MQTT where it's the user which defines the device ?

@atrovato
Copy link
Contributor

I think we can have a look to other existing platforms to handle new device types

https://developers.google.com/assistant/smarthome/guides/shutter

https://smartthings.developer.samsung.com/docs/api-ref/capabilities.html

For Google, shutter is a percent and a direction, so an integer 0 - 100 can do the job for us.
With a new device feature SHUTTER / OPEN (?).

So a simple setValue with int on this feature will do the job.
But UI is another topic.

@Pierre-Gilles
Copy link
Contributor Author

@stale
Copy link

stale bot commented Oct 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 18, 2021
@Pierre-Gilles
Copy link
Contributor Author

Ok closing this as it's a feature request, and we were already talking about it on the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants