-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brightness device feature Dashboard #1082
Brightness device feature Dashboard #1082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 532 532
Lines 7166 7168 +2
=======================================
+ Hits 6849 6851 +2
Misses 317 317
Continue to review full report at Codecov.
|
Nice to have, you use a simple slider, be carefull with device long names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! This is the same slider from multi level device. So broken too on Chrome. |
Confirmed on chrome, is this tabler related issue ? |
Not something as simple, in your version input is styled. Latest tabler use nouislider plugin and style are applied on div. I let you decide what to do, but maybe this chrome behavior is something acceptable ( the slider works ). And when tabler will be updated ( a lot of work ) slider will be ok on chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)- [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR add brightness slider to dashboard