Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to send a new device feature state in Gladys Plus Open API #1184

Merged
merged 4 commits into from May 7, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 7, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Little demo:

Screenshot 2021-05-07 at 12 37 03

Screenshot 2021-05-07 at 12 37 28

@Pierre-Gilles Pierre-Gilles changed the title Add the ability to send a new device feature state in Gladys Plus Ope… Add the ability to send a new device feature state in Gladys Plus Open API May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1184 (75569d2) into master (0f4f052) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1184      +/-   ##
==========================================
+ Coverage   96.42%   96.44%   +0.02%     
==========================================
  Files         643      643              
  Lines        8193     8196       +3     
==========================================
+ Hits         7900     7905       +5     
+ Misses        293      291       -2     
Impacted Files Coverage Δ
server/lib/gateway/gateway.handleNewMessage.js 90.32% <100.00%> (+8.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4f052...75569d2. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 2088670 into master May 7, 2021
@Pierre-Gilles Pierre-Gilles deleted the add-gladys-plus-open-api-device-state branch May 7, 2021 05:25
Jean-PhilippeD pushed a commit to Jean-PhilippeD/Gladys that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant