Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1293 : Telegram messages should be formatted with the right user unit preferences #1363

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Nov 12, 2021

Job #151: Bundle Size — 6.67MB (0%).

bcbb123 vs 7ed2d52

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0% 42.72%
Changed assets by type (0/7)

No changes


View Job #151 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1363 (a78af0a) into master (7ed2d52) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         613      613           
  Lines        8729     8729           
=======================================
  Hits         8427     8427           
  Misses        302      302           
Impacted Files Coverage Δ
server/lib/user/user.getByTelegramUserId.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed2d52...a78af0a. Read the comment docs.

Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
A simple question, why getting some attributes and not entire user?

server/lib/user/user.getByTelegramUserId.js Show resolved Hide resolved
@Pierre-Gilles
Copy link
Contributor Author

A simple question, why getting some attributes and not entire user?

@atrovato Because the entire user contains the password hash, we don't want it there :)

@Pierre-Gilles Pierre-Gilles merged commit bcbb123 into master Nov 12, 2021
@Pierre-Gilles Pierre-Gilles deleted the fix-telegram-temperature-unit-bug branch November 12, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants