Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to create trigger in scene based on calendar events #1443

Merged
merged 13 commits into from Feb 25, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Feb 22, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1443 (fdb6a02) into master (00d099d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +0.01%     
==========================================
  Files         613      614       +1     
  Lines        8758     8814      +56     
==========================================
+ Hits         8456     8511      +55     
- Misses        302      303       +1     
Impacted Files Coverage Δ
server/models/scene.js 93.75% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/api/controllers/calendar.controller.js 100.00% <100.00%> (ø)
server/lib/calendar/calendar.get.js 100.00% <100.00%> (ø)
server/lib/scene/index.js 100.00% <100.00%> (ø)
server/lib/scene/scene.checkCalendarTriggers.js 100.00% <100.00%> (ø)
server/lib/scene/scene.init.js 100.00% <100.00%> (ø)
server/models/calendar.js 88.88% <100.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d099d...fdb6a02. Read the comment docs.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review February 25, 2022 11:12
@relativeci
Copy link

relativeci bot commented Feb 25, 2022

Job #201: Bundle Size — 6.7MB (0%).

b345e65 vs b345e65

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 0% 50.53%
Changed assets by type (0/7)

No changes


View Job #201 report on app.relative-ci.com

@Pierre-Gilles Pierre-Gilles merged commit b345e65 into master Feb 25, 2022
@Pierre-Gilles Pierre-Gilles deleted the calendar-event-triggers branch February 25, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant