Broadlink

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Broadlink service.

See https://community.gladysassistant.com/t/broadlink-service/7157

I also wrote many Cypress tests, which can show how it works.

Documentation: GladysAssistant/v4-website#131

[codecov]

Codecov Report

Base: 96.66% // Head: 96.75% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (239e2d7) compared to base (122d9c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   96.66%   96.75%   +0.09%     
==========================================
  Files         630      652      +22     
  Lines        9289     9593     +304     
==========================================
+ Hits         8979     9282     +303     
- Misses        310      311       +1     

Impacted Files	Coverage Δ
server/utils/constants.js	100.00% <ø> (ø)
...ver/services/broadlink/api/broadlink.controller.js	100.00% <100.00%> (ø)
server/services/broadlink/index.js	100.00% <100.00%> (ø)
.../broadlink/lib/commands/broadlink.addPeripheral.js	100.00% <100.00%> (ø)
...roadlink/lib/commands/broadlink.buildPeripheral.js	100.00% <100.00%> (ø)
...ices/broadlink/lib/commands/broadlink.getDevice.js	100.00% <100.00%> (ø)
...broadlink/lib/commands/broadlink.getPeripherals.js	100.00% <100.00%> (ø)
.../services/broadlink/lib/commands/broadlink.init.js	100.00% <100.00%> (ø)
...ces/broadlink/lib/commands/broadlink.loadMapper.js	100.00% <100.00%> (ø)
.../services/broadlink/lib/commands/broadlink.poll.js	100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Pierre-Gilles]

I just did a first review of this PR: great work 🥳

The code is clear, and it's a PR that many people are waiting for !

I have a few feedbacks for discussion, let me know what you think.

[atrovato]

See documentation PR: GladysAssistant/v4-website#131

[atrovato]

@Pierre-Gilles I can't see the pending requested change, as I resolved all your comments.
This is ready to merge :) with documentation GladysAssistant/v4-website#131

[Pierre-Gilles]

Looks fine to me with the changes! Let's go ! 🚀

[relativeci]

Job #461: Bundle Size — 7.01MB (+2.35%).

f2ae7ba vs c80a3b6

Changed metrics (6/10)

Metric	Current	Baseline
Initial JS	2.97MB(+3%)	2.89MB
Initial CSS	294.38KB(+0.03%)	294.29KB
Cache Invalidation	50.89%	41.99%
Assets	145(+0.69%)	144
Modules	1280(+1.59%)	1260
Duplicate Code	0.52%(-1.89%)	0.53%

Changed assets by type (3/7)

	Current	Baseline
CSS	312.36KB (+0.03%)	312.26KB
IMG	1.62MB (+4.05%)	1.55MB
JS	4.98MB (+2%)	4.88MB

---

View Job #461 report on app.relative-ci.com