Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota: Add more temp devices #1570

Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Jul 14, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Allow BL09XX, DS18x20 and ESP32 temperature features from Tasmota service.
According to the subjects

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Base: 96.77% // Head: 96.70% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (8edb050) compared to base (505df71).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   96.77%   96.70%   -0.07%     
==========================================
  Files         654      648       -6     
  Lines        9662     9352     -310     
==========================================
- Hits         9350     9044     -306     
+ Misses        312      308       -4     
Impacted Files Coverage Δ
server/services/tasmota/lib/features/humidity.js 100.00% <ø> (ø)
...ervices/tasmota/lib/features/device_temperature.js 100.00% <100.00%> (ø)
server/services/tasmota/lib/features/index.js 98.38% <100.00%> (+0.02%) ⬆️
...erver/services/tasmota/lib/features/temperature.js 100.00% <100.00%> (ø)
server/utils/device.js
server/utils/constants.js
server/utils/slugify.js
server/lib/device/index.js
server/lib/index.js
server/models/device.js
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atrovato atrovato force-pushed the tasmota-temperature-features branch from 1d02108 to 063fa01 Compare July 14, 2022 17:43
@atrovato atrovato force-pushed the tasmota-temperature-features branch from 063fa01 to 11fc56e Compare August 26, 2022 07:30
@atrovato atrovato changed the title Add BL09XX/ESP32 temp devices Add more temp devices Aug 26, 2022
@atrovato atrovato marked this pull request as ready for review September 10, 2022 20:16
@Pierre-Gilles
Copy link
Contributor

Looks fine for me, maybe can you ask for testers on the forum?

@VonOx
Copy link
Contributor

VonOx commented Sep 12, 2022

Just asking

Not using global match is for filtering device_temperature feature, right ?

Reference post: https://community.gladysassistant.com/t/thr320-sonoff-tasmota-resolution-problemes/7495/12?u=vonox

@atrovato
Copy link
Contributor Author

I just rebase it on master.

@Pierre-Gilles I am generating an up-to-date Docker image, I will ask for testers.
@VonOx The device temp matcher is only on the ENERGY sensor BL09XX. All others are as temperature sensor (not device) and I didn't use generic pattern for now to match them all, I have to check all cases in Tasmota firmware before that.

@Pierre-Gilles Pierre-Gilles merged commit 3d27d12 into GladysAssistant:master Oct 3, 2022
@relativeci
Copy link

relativeci bot commented Oct 3, 2022

Job #517: Bundle Size — 7.02MB (0%).

3d27d12 vs ce240d4

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 42.34%
Changed assets by type (0/7)

No changes


View Job #517 full report

@Pierre-Gilles Pierre-Gilles changed the title Add more temp devices Tasmota: Add more temp devices Oct 3, 2022
euguuu pushed a commit to euguuu/Gladys that referenced this pull request Oct 4, 2022
* Add BL09XX temp devices

* Add ESP32 temp devices

* Add DS18x20 temp device

* Generic temp/humidity discover
@atrovato atrovato deleted the tasmota-temperature-features branch October 31, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants