Temporary fix on npm security audit to unlock PRs #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b64c401
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cfc2d60f.gladys-plus.pages.dev |
| Branch Preview URL: | https://disable-dependencies-check-w.gladys-plus.pages.dev |
Codecov ReportBase: 96.81% // Head: 96.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 660 660
Lines 9628 9628
=======================================
Hits 9321 9321
Misses 307 307 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Job #650: Bundle Size — 7.05MiB (0%).
Metrics (1 change)
Total size by type (no changes)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)Description of change
I'm currently migrating to Socket.io >= 4 but this is a long time consuming task that implies some refactoring on Gladys Plus side.
In the meantime, I'm unlocking PRs with this fix.