Duplicate scene

[callemand]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

The purpose of this PR is a proposal to add scene duplication on edit scene page.

[codecov]

Codecov Report

Base: 97.25% // Head: 97.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3805381) compared to base (a4eb84f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1670   +/-   ##
=======================================
  Coverage   97.25%   97.26%           
=======================================
  Files         642      643    +1     
  Lines        9671     9684   +13     
=======================================
+ Hits         9406     9419   +13     
  Misses        265      265           

Impacted Files	Coverage Δ
server/api/routes.js	98.03% <ø> (ø)
server/api/controllers/scene.controller.js	100.00% <100.00%> (ø)
server/lib/scene/index.js	100.00% <100.00%> (ø)
server/lib/scene/scene.duplicate.js	100.00% <100.00%> (ø)
server/seeders/20190227043234-scene.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Pierre-Gilles]

Thank you so much for this PR 🙏

This is great work and it works very well on my machine 😄

I just have a few small feedbacks, it's really nothing.

After that, I'm good to merge!

[Pierre-Gilles]

Thanks for your changes it's perfect now 🙏

I just found a last tiny 1 line change that I didn't see last time, sorry 😂

I merge this right after the change! Thanks!

[Pierre-Gilles]

Thanks for the changes, it's good for me ! ✅

[relativeci]

Job #905: Bundle Size — 6.97MiB (+0.17%).

5154c19(current) vs a4eb84f master#896(baseline)

Metrics (4 changes)

	Current Job #905	Baseline Job #896
Initial JS	3.02MiB(+0.39%)	3.01MiB
Initial CSS	293.9KiB(+0.11%)	293.57KiB
Cache Invalidation	47.26%	43.23%
Chunks	52	52
Assets	148	148
Modules	1242(+0.32%)	1238
Duplicate Modules	2	2
Duplicate Code	0.03%	0.03%
Packages	106	106
Duplicate Packages	8	8

Total size by type (2 changes)

	Current Job #905	Baseline Job #896
CSS	311.09KiB (+0.11%)	310.75KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.64MiB	1.64MiB
JS	4.92MiB (+0.24%)	4.91MiB
Media	0B	0B
Other	4.95KiB	4.95KiB

---

View job #905 report View master branch activity