Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@atrovato [For CF builds] Button click user friendly #1674

Closed
wants to merge 8 commits into from

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Dec 16, 2022

From PR #1642

Created this PR only for CF builds!

@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 16, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e37a7b8
Status: ✅  Deploy successful!
Preview URL: https://72c2b1b5.gladys-plus.pages.dev
Branch Preview URL: https://atrovato-button-click-user-f.gladys-plus.pages.dev

View logs

@Pierre-Gilles Pierre-Gilles mentioned this pull request Dec 16, 2022
6 tasks
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 97.25% // Head: 97.27% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e37a7b8) compared to base (06d878e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   97.25%   97.27%   +0.01%     
==========================================
  Files         642      643       +1     
  Lines        9671     9686      +15     
==========================================
+ Hits         9406     9422      +16     
+ Misses        265      264       -1     
Impacted Files Coverage Δ
server/api/routes.js 98.03% <ø> (ø)
server/models/dashboard.js 100.00% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/api/controllers/scene.controller.js 100.00% <100.00%> (ø)
server/lib/scene/index.js 100.00% <100.00%> (ø)
server/lib/scene/scene.actions.js 98.11% <100.00%> (+0.66%) ⬆️
server/lib/scene/scene.duplicate.js 100.00% <100.00%> (ø)
server/seeders/20190227043234-scene.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Dec 16, 2022

Job #979: Bundle Size — 7.01MiB (+0.1%).

e37a7b8(current) vs 3d2ffc8 master#952(baseline)

Metrics (3 changes)
                 Current
Job #979
     Baseline
Job #952
Initial JS 3.03MiB(+0.16%) 3.03MiB
Initial CSS 294.78KiB 294.78KiB
Cache Invalidation 47.52% 0%
Chunks 52 52
Assets 148 148
Modules 1264(+0.48%) 1258
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111 111
Duplicate Packages 8 8
Total size by type (1 change)
                 Current
Job #979
     Baseline
Job #952
CSS 312.43KiB 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.96MiB (+0.14%) 4.95MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #979 reportView atrovato-button-click-user-frien... branch activity

@Pierre-Gilles
Copy link
Contributor Author

@VonOx @atrovato New build done!

@Pierre-Gilles Pierre-Gilles deleted the atrovato-button-click-user-friendly branch February 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants