Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: user can now re-order his dashboard list #1701

Merged
merged 8 commits into from Feb 3, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jan 27, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)

Description of change

Screenshot 2023-01-30 at 15 36 09

dashboard-reorder-mobile-ux

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef8ee5e
Status: ✅  Deploy successful!
Preview URL: https://dfa0ea3f.gladys-plus.pages.dev
Branch Preview URL: https://re-order-dashboards-list.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 97.28% // Head: 97.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ef8ee5e) compared to base (c3d6921).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1701   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         644      645    +1     
  Lines        9712     9724   +12     
=======================================
+ Hits         9448     9460   +12     
  Misses        264      264           
Impacted Files Coverage Δ
server/api/routes.js 98.03% <ø> (ø)
server/lib/dashboard/dashboard.get.js 100.00% <ø> (ø)
server/lib/dashboard/dashboard.getBySelector.js 100.00% <ø> (ø)
server/models/dashboard.js 100.00% <ø> (ø)
server/api/controllers/dashboard.controller.js 100.00% <100.00%> (ø)
server/lib/dashboard/dashboard.create.js 100.00% <100.00%> (ø)
server/lib/dashboard/dashboard.updateOrder.js 100.00% <100.00%> (ø)
server/lib/dashboard/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review February 3, 2023 03:19
@relativeci
Copy link

relativeci bot commented Feb 3, 2023

Job #1041: Bundle Size — 7.19MiB (+2.14%).

102d327(current) vs c3d6921 master#1034(baseline)

Metrics (9 changes)
                 Current
Job #1041
     Baseline
Job #1034
Initial JS 4.2MiB(+37.65%) 3.05MiB
Initial CSS 299.68KiB(+0.97%) 296.8KiB
Cache Invalidation 70.32% 43.17%
Chunks 51 51
Assets 149(+0.68%) 148
Modules 1335(+5.95%) 1260
Duplicate Modules 1(-50%) 2
Duplicate Code 0.01%(-66.67%) 0.03%
Packages 116(+4.5%) 111
Duplicate Packages 4(-50%) 8
Total size by type (3 changes)
                 Current
Job #1041
     Baseline
Job #1034
CSS 312.81KiB (+0.12%) 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 5.11MiB (+2.82%) 4.97MiB
Media 0B 0B
Other 15.74KiB (+221.44%) 4.9KiB

View job #1041 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit 102d327 into master Feb 3, 2023
@Pierre-Gilles Pierre-Gilles deleted the re-order-dashboards-list branch February 3, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant