Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scene description #1778

Merged

Conversation

callemand
Copy link
Contributor

@callemand callemand commented May 11, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Screenshot 2023-05-11 at 20 47 04
Screenshot 2023-05-11 at 16 47 28

@callemand callemand marked this pull request as ready for review May 16, 2023 13:36
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (1dda59b) 97.79% compared to head (0167296) 97.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   97.79%   97.81%   +0.01%     
==========================================
  Files         702      705       +3     
  Lines       10852    10880      +28     
==========================================
+ Hits        10613    10642      +29     
+ Misses        239      238       -1     
Impacted Files Coverage Δ
server/lib/scene/scene.duplicate.js 100.00% <ø> (ø)
server/lib/scene/scene.get.js 100.00% <ø> (ø)
server/models/scene.js 93.75% <ø> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles changed the base branch from master to improve-scene-ui-ux May 26, 2023 03:10
@Pierre-Gilles Pierre-Gilles merged commit a2a4b61 into GladysAssistant:improve-scene-ui-ux May 26, 2023
9 checks passed
@callemand callemand deleted the SceneDescription branch July 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants