Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overkiz #1785

Closed
wants to merge 64 commits into from
Closed

Overkiz #1785

wants to merge 64 commits into from

Conversation

rpochet
Copy link
Contributor

@rpochet rpochet commented May 13, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • [x ] Is the linter passing? (npm run eslint on both front/server)
  • [ x] Did you run prettier? (npm run prettier on both front/server)
  • [ x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for devices using Overkiz protocol

@rpochet rpochet changed the title Initial commit Overkiz May 13, 2023
@relativeci
Copy link

relativeci bot commented Sep 4, 2023

Job #2052: Bundle Size — 9.11MiB (+1.02%).

3bee751(current) vs 7c2854c master#2050(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
Job #2052
     Baseline
Job #2050
Regression  Initial JS 4.92MiB(+1.17%) 4.86MiB
Regression  Initial CSS 302.54KiB(+0.05%) 302.38KiB
Change  Cache Invalidation 67.65% 57.2%
No change  Chunks 51 51
Change  Assets 158(+0.64%) 157
Change  Modules 1416(+1.14%) 1400
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
Job #2052
     Baseline
Job #2050
Regression  JS 6.58MiB (+0.92%) 6.52MiB
Regression  IMG 2.1MiB (+1.55%) 2.06MiB
Regression  CSS 318.92KiB (+0.05%) 318.76KiB
Not changed  Fonts 93.55KiB 93.55KiB
Regression  Other 16.14KiB (+0.51%) 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2052 reportView rpochet:overkiz branch activity

Copy link

stale bot commented Jan 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 26, 2024
@stale stale bot closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant