Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker node red integration #1809

Merged
merged 32 commits into from
Oct 27, 2023
Merged

Docker node red integration #1809

merged 32 commits into from
Oct 27, 2023

Conversation

callemand
Copy link
Contributor

@callemand callemand commented Jun 8, 2023 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)

Description of change

Provide a new service to start node-red into docker and follow the status.

Screenshot 2023-06-08 at 15 11 38 Screenshot 2023-06-08 at 15 11 52

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
server/services/index.js 100.00% <100.00%> (ø)
...erver/services/node-red/api/node-red.controller.js 100.00% <100.00%> (ø)
server/services/node-red/index.js 100.00% <100.00%> (ø)
.../services/node-red/lib/checkForContainerUpdates.js 100.00% <100.00%> (ø)
server/services/node-red/lib/configureContainer.js 100.00% <100.00%> (ø)
server/services/node-red/lib/constants.js 100.00% <100.00%> (ø)
server/services/node-red/lib/disconnect.js 100.00% <100.00%> (ø)
server/services/node-red/lib/getConfiguration.js 100.00% <100.00%> (ø)
server/services/node-red/lib/index.js 100.00% <100.00%> (ø)
server/services/node-red/lib/init.js 100.00% <100.00%> (ø)
... and 6 more

📢 Thoughts on this report? Let us know!.

@callemand callemand marked this pull request as ready for review June 9, 2023 13:22
@relativeci
Copy link

relativeci bot commented Sep 4, 2023 •
edited
Loading

Job #1951: Bundle Size — 8.91MiB (+0.99%).

7921c55(current) vs c4766f5 master#1944(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
Job #1951		      Baseline
Job #1944
Regression  Initial JS 4.79MiB(+0.57%) 4.77MiB
Regression  Initial CSS 301.67KiB(+0.12%) 301.31KiB
Change  Cache Invalidation 58.02% 53.91%
No change  Chunks 48 48
Change  Assets 154(+1.32%) 152
Change  Modules 1383(+0.36%) 1378
No change  Duplicate Modules 19 19
No change  Duplicate Code 0.69% 0.69%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
Job #1951		      Baseline
Job #1944
Regression  JS 6.42MiB (+0.43%) 6.39MiB
Regression  IMG 2.06MiB (+2.98%) 2MiB
Regression  CSS 317.32KiB (+0.11%) 316.97KiB
Not changed  Fonts 93.55KiB 93.55KiB
Regression  Other 15.66KiB (+1.15%) 15.48KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #1951 report View callemand:DockerNodeRed branch activity

Pierre-Gilles
Pierre-Gilles requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR ! 🙏

A few feedbacks

front/src/routes/integration/all/node-red/NodeRedPage.js Outdated Show resolved Hide resolved
front/src/config/i18n/en.json Outdated Show resolved Hide resolved
server/lib/system/system.getGladysBasePath.js Outdated Show resolved Hide resolved
server/services/node-red/package.json Outdated Show resolved Hide resolved
server/services/node-red/package.json Outdated Show resolved Hide resolved
server/services/node-red/package.json Show resolved Hide resolved
Pierre-Gilles
Pierre-Gilles approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks for your work 🙏

Good for me!

@Pierre-Gilles Pierre-Gilles merged commit d96f2c9 into GladysAssistant:master Oct 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Pierre-Gilles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@callemand @Pierre-Gilles