Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera: Add a timeout to ffmpeg to prevent it from running forever #1821

Merged
merged 1 commit into from Jun 30, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix #1808

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40c7483
Status: ✅  Deploy successful!
Preview URL: https://d41a4d88.gladys-plus.pages.dev
Branch Preview URL: https://add-timeout-fluent-ffmpeg.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3101949) 97.83% compared to head (40c7483) 97.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         711      711           
  Lines       10951    10951           
=======================================
  Hits        10714    10714           
  Misses        237      237           
Impacted Files Coverage Δ
server/services/rtsp-camera/lib/getImage.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Jun 26, 2023

Job #1608: Bundle Size — 8.51MiB (0%).

b19cff3(current) vs ec0eed7 master#1606(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (1 change)
                 Current
Job #1608
     Baseline
Job #1606
Initial JS 4.58MiB 4.58MiB
Initial CSS 301.69KiB 301.69KiB
Cache Invalidation 0% 53.67%
Chunks 47 47
Assets 149 149
Modules 1343 1343
Duplicate Modules 19 19
Duplicate Code 0.68% 0.68%
Packages 124 124
Duplicate Packages 3 3
Total size by type (no changes)
                 Current
Job #1608
     Baseline
Job #1606
CSS 314.99KiB 314.99KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.89MiB 1.89MiB
JS 6.19MiB 6.19MiB
Media 0B 0B
Other 15.21KiB 15.21KiB

View job #1608 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit b19cff3 into master Jun 30, 2023
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-timeout-fluent-ffmpeg branch June 30, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTSP camera polling stays in RAM sometimes if camera query fail
1 participant