Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IKEA Tradfri On/Off E1743 Switch #1848

Merged
merged 1 commit into from Aug 25, 2023
Merged

Add IKEA Tradfri On/Off E1743 Switch #1848

merged 1 commit into from Aug 25, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Aug 25, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix #1850, Add compatibility for IKEA Tradfri On/Off E1743 Switch

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf9db22
Status: ✅  Deploy successful!
Preview URL: https://e1444b16.gladys-plus.pages.dev
Branch Preview URL: https://add-ikea-button.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Aug 25, 2023

Job #1691: Bundle Size — 8.64MiB (~+0.01%).

8145bb3(current) vs f27d0ea master#1688(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1691
     Baseline
Job #1688
Initial JS 4.69MiB(+0.01%) 4.69MiB
Initial CSS 302.01KiB 302.01KiB
Cache Invalidation 54.1% 0%
Chunks 47 47
Assets 150 150
Modules 1356 1356
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1691
     Baseline
Job #1688
CSS 315.31KiB 315.31KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.29MiB (~+0.01%) 6.29MiB
Media 0B 0B
Other 15.29KiB 15.29KiB

View job #1691 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit 8145bb3 into master Aug 25, 2023
8 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-ikea-button branch August 25, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IKEA Tradfri On/Off E1743 Switch
1 participant