Display camera by name

[callemand]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Being able to call a camera by its Name, rather than by the Name of the room where it is located

[relativeci]

Job #2019: Bundle Size — 8.99MiB (~-0.01%).

ff4bf29(current) vs 86cd2dd master#2015(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   2 changes 1 improvement

	Current Job #2019	Baseline Job #2015
Initial JS	4.84MiB(~-0.01%)	4.84MiB
Initial CSS	301.85KiB	301.85KiB
Cache Invalidation	53.74%	63.26%
Chunks	51	51
Assets	157	157
Modules	1395	1395
Duplicate Modules	20	20
Duplicate Code	0.82%	0.82%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   1 change 1 improvement

	Current Job #2019	Baseline Job #2015
JS	6.49MiB (~-0.01%)	6.49MiB
IMG	2.06MiB	2.06MiB
CSS	318.08KiB	318.08KiB
Fonts	93.55KiB	93.55KiB
Other	16.06KiB	16.06KiB
HTML	13.58KiB	13.58KiB

---

View job #2019 report View callemand:chat_display_camera_by... branch activity

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
server/lib/brain/index.js	100.00% <ø> (ø)
server/lib/device/camera/camera.command.js	95.45% <100.00%> (+1.33%)	⬆️
server/lib/device/camera/camera.getImagesInRoom.js	100.00% <100.00%> (ø)
server/lib/device/camera/index.js	100.00% <100.00%> (ø)
server/lib/device/device.create.js	98.63% <100.00%> (+0.03%)	⬆️
server/lib/device/device.init.js	100.00% <100.00%> (ø)
server/lib/device/index.js	100.00% <100.00%> (ø)
...rver/lib/gateway/gateway.forwardMessageToOpenAI.js	100.00% <100.00%> (ø)
server/lib/index.js	95.00% <100.00%> (ø)
server/utils/constants.js	100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!

[Pierre-Gilles]

Thanks for the PR! It works fine for me :) Be careful, on the code side there are some lines not covered by tests (not much :p )

For the OpenAI part, there will be 24h where it'll not working for half of the users, because as you changed the labels from "camera.get-image-room" to "camera.get-image", I'll have to update this on the ChatGPT integration too, but on users on the "old" version, it'll be broken for 24h... Not sure if I have a solution (maybe I can get the version of Gladys in the user-agent of the API call...)

Thanks for the PR 🙏

[Pierre-Gilles]

Thanks for the PR, good for me 🙏