Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning system for battery level #1936

Merged
merged 5 commits into from Nov 27, 2023

Conversation

callemand
Copy link
Contributor

@callemand callemand commented Nov 14, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Screenshot 2023-11-14 at 11 10 47
Screenshot 2023-11-14 at 11 10 38

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9466570) 98.17% compared to head (f3da5e1) 98.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1936   +/-   ##
=======================================
  Coverage   98.17%   98.18%           
=======================================
  Files         776      778    +2     
  Lines       12167    12198   +31     
=======================================
+ Hits        11945    11976   +31     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callemand callemand marked this pull request as ready for review November 17, 2023 15:08
Copy link

relativeci bot commented Nov 17, 2023

Job #2090: Bundle Size — 9.02MiB (+0.1%).

f3da5e1(current) vs 9466570 master#2089(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #2090
     Baseline
Job #2089
Regression  Initial JS 4.87MiB(+0.18%) 4.86MiB
No change  Initial CSS 302.35KiB 302.35KiB
Change  Cache Invalidation 53.8% 0%
No change  Chunks 51 51
No change  Assets 157 157
Change  Modules 1409(+0.57%) 1401
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2090
     Baseline
Job #2089
Regression  JS 6.53MiB (+0.14%) 6.52MiB
Not changed  IMG 2.06MiB 2.06MiB
Not changed  CSS 318.72KiB 318.72KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.06KiB 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2090 reportView callemand:warning_battery_level branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for this PR :)

I'm able to enter absurd values in the field:

Screenshot 2023-11-27 at 14 17 49

Could we make it only work between 0 and 100 ?

Otherwise it looks good!

}
},
"batteryLevel": "Alerte sur le niveau de batterie",
"batteryLevelDescription": "A 09h00, uniquement le samedi, un message sera envoyer à tous les admins dès que le niveau du batterie parsera en dessous du pourcentage choisi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

"À 09h00, uniquement le samedi, un message sera envoyé à tous les admins dès que le niveau de la batterie parsera en dessous du pourcentage choisi"

@Pierre-Gilles Pierre-Gilles merged commit f3da5e1 into GladysAssistant:master Nov 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants