Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hue icon #1937

Closed
wants to merge 1 commit into from
Closed

Conversation

callemand
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Just adding Hue icons

Screenshot 2023-11-15 at 16 11 37 Screenshot 2023-11-15 at 16 11 30

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30ce850) 98.17% compared to head (3d8e651) 98.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1937   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         773      773           
  Lines       12133    12133           
=======================================
  Hits        11911    11911           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 15, 2023

Job #2040: Bundle Size — 9.02MiB (+0.3%).

3d8e651(current) vs 30ce850 master#2032(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2040
     Baseline
Job #2032
Regression  Initial JS 4.87MiB(+0.55%) 4.85MiB
No change  Initial CSS 301.85KiB 301.85KiB
Change  Cache Invalidation 53.92% 53.75%
No change  Chunks 51 51
No change  Assets 157 157
No change  Modules 1396 1396
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2040
     Baseline
Job #2032
Regression  JS 6.52MiB (+0.41%) 6.5MiB
Not changed  IMG 2.06MiB 2.06MiB
Not changed  CSS 318.08KiB 318.08KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.06KiB 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2040 reportView callemand:adding_hue_icons branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed something, but I don't see where the hue icons are in this PR ? 🤔

Edit: My bad, didn't see the other PR !!

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said on the community, those icons are unfortunately trademarked and cannot be used in open-source projects :/

I'm closing this... Maybe we can investigate another icon library ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants