Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt: Add illuminance sensor #1979

Merged
merged 1 commit into from Dec 15, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Add illuminance sensor ( https://en-community.gladysassistant.com/t/gladys-assistant-4-31-tag-filter-mqtt-in-scenes/147/3 )

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a0ab8e
Status: ✅  Deploy successful!
Preview URL: https://2040cf69.gladys-plus.pages.dev
Branch Preview URL: https://zigbee2mqtt-add-illuminance.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Dec 15, 2023

Job #2174: Bundle Size — 9.09MiB (0%).

6a0ab8e(current) vs 4fa39d6 master#2172(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2174
     Baseline
Job #2172
No change  Initial JS 4.91MiB 4.91MiB
No change  Initial CSS 302.47KiB 302.47KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 158 158
No change  Modules 1421 1421
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #2174
     Baseline
Job #2172
Not changed  JS 6.57MiB 6.57MiB
Not changed  IMG 2.08MiB 2.08MiB
Not changed  CSS 318.98KiB 318.98KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2174 reportView zigbee2mqtt-add-illuminance-sens... branch activity

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fa39d6) 98.19% compared to head (6a0ab8e) 98.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1979   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         785      785           
  Lines       12282    12282           
=======================================
  Hits        12060    12060           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 9b2e67b into master Dec 15, 2023
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the zigbee2mqtt-add-illuminance-sensor branch December 15, 2023 09:07
feature: {
category: DEVICE_FEATURE_CATEGORIES.LIGHT_SENSOR,
type: DEVICE_FEATURE_TYPES.SENSOR.DECIMAL,
unit: DEVICE_FEATURE_UNITS.LUX,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Gilles unit should not be LUX !
It is RAW illuminance value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants