Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt: Add philips hue dimmer switch 324131092621 #2009

Merged

Conversation

William-De71
Copy link
Contributor

@William-De71 William-De71 commented Jan 28, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add philips hue dimmer switch 324131092621

Philips Hue Dimmer Switch

Copy link

relativeci bot commented Jan 28, 2024

Job #2283: Bundle Size — 9.64MiB (+0.01%).

495dbc3(current) vs 49c8237 master#2256(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2283
     Baseline
Job #2256
Regression  Initial JS 5.23MiB(+0.02%) 5.23MiB
No change  Initial CSS 302.56KiB 302.56KiB
Change  Cache Invalidation 54.2% 0%
No change  Chunks 51 51
No change  Assets 161 161
No change  Modules 1436 1436
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2283
     Baseline
Job #2256
Regression  JS 6.92MiB (+0.02%) 6.92MiB
Not changed  IMG 2.28MiB 2.28MiB
Not changed  CSS 319.07KiB 319.07KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.5KiB 16.5KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2283 reportView William-De71:add-Philips-3241310... branch activityView project dashboard

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49c8237) 98.21% compared to head (495dbc3) 98.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2009   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         800      800           
  Lines       12492    12500    +8     
=======================================
+ Hits        12269    12277    +8     
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit a428cd5 into GladysAssistant:master Jan 29, 2024
9 checks passed
@William-De71 William-De71 deleted the add-Philips-324131092621 branch February 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants