Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zwavejs] Support Air Temperature & Power properties from Multilevel Sensor Command Class #2027

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

sescandell
Copy link
Contributor

@sescandell sescandell commented Feb 15, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support of the Air Temperature & Power properties from the Multilevel Sensor Command class:
image

Tested on real device:

  • Air temperature: with the Fibaro Door/Window Sensor 2 (not at all the best device for this data... a dedicated one would be prefered)
  • Power: Fibaro wall plug

MQTT message samples (grabbed and tested from zWaveJS UI):
image
image

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (185fe8a) to head (e3bd5cf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         836      836           
  Lines       13269    13286   +17     
=======================================
+ Hits        13047    13064   +17     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Feb 15, 2024

Job #2395: Bundle Size — 9.83MiB (0%).

e3bd5cf(current) vs 185fe8a master#2390(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2395
     Baseline
Job #2390
No change  Initial JS 5.34MiB 5.34MiB
No change  Initial CSS 303.16KiB 303.16KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 165 165
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #2395
     Baseline
Job #2390
Not changed  JS 7.03MiB 7.03MiB
Not changed  IMG 2.37MiB 2.37MiB
Not changed  CSS 319.67KiB 319.67KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.93KiB 16.93KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2395 reportView sescandell:zwavejs-temperature branch activityView project dashboard

@sescandell
Copy link
Contributor Author

PR for documentation is available here: GladysAssistant/v4-website#255

@Pierre-Gilles Pierre-Gilles merged commit d198227 into GladysAssistant:master Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants