Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT: Fix setup page on Firefox #2046

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Pierre-Gilles Pierre-Gilles changed the title MQTT: Fix setup page of Firefox MQTT: Fix setup page on Firefox Mar 25, 2024
Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9e5a50
Status: ✅  Deploy successful!
Preview URL: https://67c6ba9f.gladys-plus.pages.dev
Branch Preview URL: https://fix-mqtt-page-firefox.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Mar 25, 2024

Job #2439: Bundle Size — 10.03MiB (~+0.01%).

e9e5a50(current) vs a3f5539 master#2435(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2439
     Baseline
Job #2435
Regression  Initial JS 5.37MiB(~+0.01%) 5.37MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.42% 62.51%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1457 1457
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2439
     Baseline
Job #2435
Regression  JS 7.13MiB (~+0.01%) 7.13MiB
Not changed  IMG 2.46MiB 2.46MiB
Not changed  CSS 319.71KiB 319.71KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 17.53KiB 17.53KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2439 reportView fix-mqtt-page-firefox branch activityView project dashboard

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (a3f5539) to head (e9e5a50).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         844      844           
  Lines       13743    13743           
=======================================
  Hits        13521    13521           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 5dd170f into master Mar 25, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-mqtt-page-firefox branch March 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant