Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt : Remove duplicate features in getDiscoveredDevices to fix bug on Aqara motion sensor #2057

Merged
merged 1 commit into from Apr 22, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Apr 21, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix bug on Aqara motion sensor ( https://community.gladysassistant.com/t/conflict-lors-de-lajout-dun-device-z2m/6736/21 )

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 825ffb1
Status: ✅  Deploy successful!
Preview URL: https://efefc352.gladys-plus.pages.dev
Branch Preview URL: https://fix-zigbee2mqtt-aqara.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (2251726) to head (825ffb1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2057   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         844      844           
  Lines       13760    13766    +6     
=======================================
+ Hits        13538    13544    +6     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Apr 21, 2024

Job #2469: Bundle Size — 10.04MiB (0%).

825ffb1(current) vs 2251726 master#2468(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2469
     Baseline
Job #2468
No change  Initial JS 5.38MiB 5.38MiB
No change  Initial CSS 303.21KiB 303.21KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1459 1459
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #2469
     Baseline
Job #2468
Not changed  JS 7.14MiB 7.14MiB
Not changed  IMG 2.46MiB 2.46MiB
Not changed  CSS 319.71KiB 319.71KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 17.53KiB 17.53KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2469 reportView fix-zigbee2mqtt-aqara branch activityView project dashboard

@Pierre-Gilles Pierre-Gilles merged commit 5151c99 into master Apr 22, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-zigbee2mqtt-aqara branch April 22, 2024 08:21
William-De71 pushed a commit to William-De71/Gladys that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant